Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates sponsor-related display text and data to reflect a new last-updated date and refreshed top-10 sponsor list, keeping the Vue app and README in sync. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- The sponsor list and last-updated date are duplicated in both
App.vueandREADME.md; consider centralizing this data (e.g., in a JSON or config file) so that future updates only need to be made in one place. - You may want to standardize the date format (e.g.,
2026-03-05or locale-aware formatting) rather than hardcoding a free-form string inside the translatable text, which will make future updates and localization easier.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The sponsor list and last-updated date are duplicated in both `App.vue` and `README.md`; consider centralizing this data (e.g., in a JSON or config file) so that future updates only need to be made in one place.
- You may want to standardize the date format (e.g., `2026-03-05` or locale-aware formatting) rather than hardcoding a free-form string inside the translatable text, which will make future updates and localization easier.
## Individual Comments
### Comment 1
<location path="static/src/App.vue" line_range="266-267" />
<code_context>
sponsorHint: {
- en: 'The website is free, open-source, and kept simple. If you want to support the author, please scan the sponsor code with WeChat. Below are the top 10 sponsors (last updated on 2025.1.21)',
- zh: '网站免费、开源、保持简单,如果你想支持作者,请使用微信扫描赞赏码,以下是赞赏榜的前10名赞助者(最后更新 2025.9.10)',
+ en: 'The website is free, open-source, and kept simple. If you want to support the author, please scan the sponsor code with WeChat. Below are the top 10 sponsors (last updated on 2026.3.5)',
+ zh: '网站免费、开源、保持简单,如果你想支持作者,请使用微信扫描赞赏码,以下是赞赏榜的前10名赞助者(最后更新 2026.3.5)',
},
no: {
</code_context>
<issue_to_address>
**suggestion:** Avoid hardcoding the 'last updated' date in localized strings to reduce maintenance overhead.
The date is duplicated in both English and Chinese strings, so it must be updated in multiple places each time sponsor data changes. Instead, derive it from a single source (e.g., a `sponsorLastUpdated` constant or sponsor data) and interpolate it into the localized strings to keep them in sync automatically.
Suggested implementation:
```
sponsorHint: {
en: `The website is free, open-source, and kept simple. If you want to support the author, please scan the sponsor code with WeChat. Below are the top 10 sponsors (last updated on ${sponsorLastUpdated})`,
zh: `网站免费、开源、保持简单,如果你想支持作者,请使用微信扫描赞赏码,以下是赞赏榜的前10名赞助者(最后更新 ${sponsorLastUpdated})`,
},
```
To fully implement this, you also need to introduce a single source of truth for `sponsorLastUpdated`:
1. If this file uses a normal `<script>` block with `export default`:
- Add a module-level constant near the top of the script:
```js
const sponsorLastUpdated = '2026.3.5';
```
- Place it just after `<script>` and before `export default { ... }`.
2. If this file uses `<script setup>`:
- Add the same constant inside the `<script setup>` block:
```js
const sponsorLastUpdated = '2026.3.5';
```
3. For a more robust solution, consider deriving `sponsorLastUpdated` from your sponsor data (e.g., a `lastUpdated` field on the sponsor list) instead of hardcoding `'2026.3.5'`. In that case, ensure `sponsorLastUpdated` is computed once and reused in the sponsorHint strings.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| en: 'The website is free, open-source, and kept simple. If you want to support the author, please scan the sponsor code with WeChat. Below are the top 10 sponsors (last updated on 2026.3.5)', | ||
| zh: '网站免费、开源、保持简单,如果你想支持作者,请使用微信扫描赞赏码,以下是赞赏榜的前10名赞助者(最后更新 2026.3.5)', |
There was a problem hiding this comment.
suggestion: Avoid hardcoding the 'last updated' date in localized strings to reduce maintenance overhead.
The date is duplicated in both English and Chinese strings, so it must be updated in multiple places each time sponsor data changes. Instead, derive it from a single source (e.g., a sponsorLastUpdated constant or sponsor data) and interpolate it into the localized strings to keep them in sync automatically.
Suggested implementation:
sponsorHint: {
en: `The website is free, open-source, and kept simple. If you want to support the author, please scan the sponsor code with WeChat. Below are the top 10 sponsors (last updated on ${sponsorLastUpdated})`,
zh: `网站免费、开源、保持简单,如果你想支持作者,请使用微信扫描赞赏码,以下是赞赏榜的前10名赞助者(最后更新 ${sponsorLastUpdated})`,
},
To fully implement this, you also need to introduce a single source of truth for sponsorLastUpdated:
-
If this file uses a normal
<script>block withexport default:- Add a module-level constant near the top of the script:
const sponsorLastUpdated = '2026.3.5';
- Place it just after
<script>and beforeexport default { ... }.
- Add a module-level constant near the top of the script:
-
If this file uses
<script setup>:- Add the same constant inside the
<script setup>block:const sponsorLastUpdated = '2026.3.5';
- Add the same constant inside the
-
For a more robust solution, consider deriving
sponsorLastUpdatedfrom your sponsor data (e.g., alastUpdatedfield on the sponsor list) instead of hardcoding'2026.3.5'. In that case, ensuresponsorLastUpdatedis computed once and reused in the sponsorHint strings.
Summary by Sourcery
Update sponsor metadata and documentation to reflect the latest sponsor list and last updated date.
Enhancements:
Documentation: